Skip to content

Rename prefix of binaryCompatibilityValidator properties#42041

Closed
mdvacca wants to merge 1 commit into
facebook:mainfrom
mdvacca:export-D52380035
Closed

Rename prefix of binaryCompatibilityValidator properties#42041
mdvacca wants to merge 1 commit into
facebook:mainfrom
mdvacca:export-D52380035

Conversation

@mdvacca
Copy link
Copy Markdown
Contributor

@mdvacca mdvacca commented Dec 21, 2023

Summary:
binaryCompatibilityValidator is a generic library, it shouldn't have referecences to react. I'm renaming:

react.internal.binaryCompatibilityValidator...

by

binaryCompatibilityValidator...

changelog: [internal] internal

Reviewed By: philIip

Differential Revision: D52380035

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Dec 21, 2023
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52380035

)

Summary:

binaryCompatibilityValidator is a generic library, it shouldn't have referecences to react. I'm renaming:

```
react.internal.binaryCompatibilityValidator...
```

by

```
binaryCompatibilityValidator...
```

changelog: [internal] internal

Reviewed By: philIip

Differential Revision: D52380035
@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request was exported from Phabricator. Differential Revision: D52380035

@analysis-bot
Copy link
Copy Markdown

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,593,748 +12
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,966,593 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 9271957
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

This pull request has been merged in fa470ef.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants